t+1 - Latest Comments in The gauntlet software pattern

Re: The gauntlet software pattern

Matt Wilson — Tue, 08 Nov 2011 17:05:52 -0000

Hey, thanks for the comment!

Stuff like this is largely a matter of taste rather than hard science. Your way is more readable to you, but for me, the multiple returns are a signal to me that I can immediately stop reading.

Re: The gauntlet software pattern

MattO — Tue, 08 Nov 2011 16:55:25 -0000

I think an if else statement is just as efficient / readable and you can still end up with a single return statement.

bool rValue = true;

if( not a ){
rValue = false;
}else if (not b){
rValue = false;
}

return rValue;

multiple return statements turn into a nightmare when using loops. My preference is to use a single return statement. I have seen too many times where multiple statements turn ugly, and haven't yet see a use case where sticking to a single return is mutually exclusive from good code. these are just my thoughts however. they may be wrong.

Re: The gauntlet software pattern

Dave — Fri, 16 Sep 2011 16:51:41 -0000

Error in code above -- what if (a && b && c && !(d || e) && !(f && g))
in the original code, nothing is returned, in both subsequent examples, different values are returned.

Re: The gauntlet software pattern

Matt Wilson — Wed, 30 Mar 2011 10:50:09 -0000

Przemyslaw -- thanks for the links!

Re: The gauntlet software pattern

Przemyslaw Pokrywka — Wed, 30 Mar 2011 10:14:58 -0000

Folks, that pattern already has its name: it's "guard clause". See http://c2.com/cgi/wiki?GuardCl... or http://www.refactoring.com/cat...

Re: The gauntlet software pattern

Matt Wilson — Sun, 27 Feb 2011 13:58:05 -0000

Yup -- that's exactly what I'm going for here; that flag that says
"you're all done!".

What is up with those one-return-statement guys?

Re: The gauntlet software pattern

jackdied — Sun, 27 Feb 2011 12:36:20 -0000

For some reason SE-SE (Single Entry - Single Exit) code still has a strong cargo cult appeal. I've seen people write that way even though they weren't old enough to type when the last compiler that benefited from SESE went away.

I much prefer multiple return statements. It says to the reader "you can stop reading this function now."