t+1 - Latest Comments in Rewrite my ugly code

Re: Rewrite my ugly code

Password Recovery — Tue, 03 Feb 2009 01:15:14 -0000

Man I'd help you out but it looks way too complicated for me. I am a php newb still learning from guys like you. Keep up the good work.

Re: Rewrite my ugly code

Mike Pirnat — Sun, 07 Dec 2008 09:37:06 -0000

The highlights are:
* parsing
* timezones
* recurrence
* relative deltas

The docs are quite good, so definitely worth your time to take a peek at. There's also my presentation from PyCon 2007 if you want the quick tour with some examples (beware Gilbert & Sullivan spoilers).

Re: Rewrite my ugly code

Doug Hellmann — Sat, 06 Dec 2008 20:58:57 -0000

I like that quote! And thanks, this was a fun exercise. I've been sick for a couple of days, so I haven't had my own ugly code to stare at for a while. :-)

Re: Rewrite my ugly code

Matt Wilson — Sat, 06 Dec 2008 20:54:24 -0000

That calendar.monthrange trick is nice. Allows me to forget about nonsense like leap year and special logic for December.

I read somewhere that every big python app ends up building a crappier version of what's already in the standard library. I'm happy to see I've reached that point :)

Thanks for the help!

Re: Rewrite my ugly code

Doug Hellmann — Sat, 06 Dec 2008 20:43:44 -0000

Here's my stab at it: http://blog.doughellmann.com/2...

Re: Rewrite my ugly code

Mike Pirnat — Sat, 06 Dec 2008 20:11:03 -0000

Actually now that I look at the rest of your code, I think dateutil has the strong possibility of making you very happy indeed.

Re: Rewrite my ugly code

Doug Hellmann — Sat, 06 Dec 2008 20:10:12 -0000

The standard library module "calendar" contains the function monthrange(), which will give you the numerical day of the first and last days of the month. The last day of the month in get_first_and_last_dom() becomes last_day = datetime.date(dt.year, dt.month, calendar.monthrange(dt.year,dt.month)[1])

Re: Rewrite my ugly code

Matt Wilson — Sat, 06 Dec 2008 19:44:10 -0000

Thanks Mike -- besides helping with parsing, what else can dateutil
help with? I remember you showed a bunch of neat recurrence trickery
as well. I think I should read all the docs.

Re: Rewrite my ugly code

Matt Wilson — Sat, 06 Dec 2008 19:42:09 -0000

Thanks Doug! I'm going to read up on the calendar module now. I bet
there is a lot of code I can streamline now.

Re: Rewrite my ugly code

Mike Pirnat — Sat, 06 Dec 2008 19:37:25 -0000

It's not for the function you're wanting help with, but dateutil would make much shorter work of your date parsing issues.

My typical usage for parsing date strings is (in a nutshell):

from dateutil.parser import parse as parse_date
dt = parse_date(some_date_string)

You can add your own formats to it if you need to do crazy stuff.